[bug report] staging: mt7621-mmc: MIPS: ralink: add sdhci for mt7620a SoC

Christian Lütke-Stetzkamp christian at lkamp.de
Thu Apr 5 09:46:22 PDT 2018


On Thu, Apr 05, 2018 at 02:56:54PM +0300, Dan Carpenter wrote:
> Hello John Crispin,
> 
> The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci
> for mt7620a SoC" from Mar 15, 2018, leads to the following static
> checker warning:
> 
> 	drivers/staging/mt7621-mmc/sd.c:2790 msdc_drv_probe()
> 	warn: curly braces intended?

Hi Dan,

in my understanding of the code around that place, these lines are
only indented by accident. The card detect low/high selection and the
activation of software poll should happen even when the SDIO(_EXT)
interrupt is not enabled, because they are not related.

The indentation will be fixed, once the patch series I sent yesterday
in version 2 gets merged.

Hopefully this answer is helpful,
Christian



More information about the Linux-mediatek mailing list