[PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding

Sean Wang sean.wang at mediatek.com
Mon Mar 13 23:06:35 PDT 2017


On Mon, 2017-03-13 at 17:36 +0100, Andrew Lunn wrote:
> > +- mediatek,reset-pin: Phandle to the pinctrl node used for the reset. Which
> > +	must be required if the property mediatek,mcm of specified as
> > +	"disabled". See
> > +	Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt for
> > +	the mediatek pintcrl setting for the details.
> 
> Hi Sean
> 
> This appears to be a plan GPIO line. Marvell has the same. It would be
> nice to be consistent with the naming. From
> Documentation/devicetree/bindings/net/dsa/marvell.txt
> 
> Optional properties:
> 
> - reset-gpios           : Should be a gpio specifier for a reset line
> 
>   Andrew


Hi Andrew,

I'll change the property into the consistent way, and usage for 

GPIO control be also used in devm_gpiod_* instead as you suggested

for patch 4.

	Sean




More information about the Linux-mediatek mailing list