[PATCH] PCI: mediatek: fix error handling in mtk_pcie_parse_and_add_res()
Ryder Lee
ryder.lee at mediatek.com
Sun Jun 4 23:27:58 PDT 2017
The 'linkup' variable would always increment by one whether the link
status is true or not. Therefore, this patch fixes the return value in
mtk_pcie_parse_and_add_res() and removes unnecessary 'linkup' variable.
Signed-off-by: Ryder Lee <ryder.lee at mediatek.com>
---
drivers/pci/host/pcie-mediatek.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
index 8ec8fa8..3baafa8 100644
--- a/drivers/pci/host/pcie-mediatek.c
+++ b/drivers/pci/host/pcie-mediatek.c
@@ -373,7 +373,7 @@ static int mtk_pcie_parse_and_add_res(struct mtk_pcie *pcie)
struct of_pci_range_parser parser;
struct of_pci_range range;
struct resource res;
- int err, linkup = 0;
+ int err;
/* parse shared resources */
err = mtk_pcie_handle_shared_resource(pcie);
@@ -444,11 +444,11 @@ static int mtk_pcie_parse_and_add_res(struct mtk_pcie *pcie)
/* enable each port, and then check link status */
err = mtk_pcie_enable_ports(port);
- if (!err)
- linkup++;
+ if (err)
+ return err;
}
- return !linkup;
+ return 0;
}
static int mtk_pcie_request_resources(struct mtk_pcie *pcie)
--
1.9.1
More information about the Linux-mediatek
mailing list