[PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Andi Shyti andi.shyti at samsung.com
Thu Jan 5 19:43:46 PST 2017


Hi Sean,

> +	ir->rc = rc_allocate_device();

Yes, you should use devm_rc_allocate_device(...)

Besides, standing to this patch which is not in yet:

https://lkml.org/lkml/2016/12/18/39

rc_allocate_device should provide the driver type during
allocation, so it should be:

	ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);

and this line can be removed:

> +	ir->rc->driver_type = RC_DRIVER_IR_RAW;

I don't know when Mauro will take the patch above.

Andi



More information about the Linux-mediatek mailing list