[PATCH v2 3/4] leds: Add LED support for MT6323 PMIC
Pavel Machek
pavel at ucw.cz
Thu Feb 9 06:23:44 PST 2017
Hi!
> > +/*
> > + * Register for MT6323_ISINK_CON0 to setup the
> > + * duty cycle of the blink
> > + */
> > +#define MT6323_ISINK_CON0(i) (MT6323_ISINK0_CON0 + 0x8 * (i))
> > +#define MT6323_ISINK_DIM_DUTY_MASK (0x1f << 8)
> > +#define MT6323_ISINK_DIM_DUTY(i) (((i) << 8) & \
> > + MT6323_ISINK_DIM_DUTY_MASK)
> > +
> > +/*
> > + * Register to setup the period of the blink
> > + */
>
> This fits in a single line, so can be wrapped with /* */ like :
People do this to make blocks stand out, and to make it similar to other blocks
above. I believe this is ok.
Pavel
More information about the Linux-mediatek
mailing list