[PATCH 2/2] net-next: ethernet: mediatek: change the compatible string

James Liao jamesjj.liao at mediatek.com
Wed Feb 1 21:07:29 PST 2017


On Wed, 2017-01-25 at 09:20 +0100, John Crispin wrote:
> When the binding was defined, I was not aware that mt2701 was an earlier
> version of the SoC. For sake of consistency, the ethernet driver should
> use mt2701 inside the compat string as this is the earliest SoC with the
> ethernet core.
> 
> The ethernet driver is currently of no real use until we finish and
> upstream the DSA driver. There are no users of this binding yet. It should
> be safe to fix this now before it is too late and we need to provide
> backward compatibility for the mt7623-eth compat string.
> 
> Reported-by: Sean Wang <sean.wang at mediatek.com>
> Signed-off-by: John Crispin <john at phrozen.org>

Acked-by: James Liao <jamesjj.liao at mediatek.com>

> ---
>  drivers/net/ethernet/mediatek/mtk_eth_soc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 25ae0c5..9e75768 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -2515,7 +2515,7 @@ static int mtk_remove(struct platform_device *pdev)
>  }
>  
>  const struct of_device_id of_mtk_match[] = {
> -	{ .compatible = "mediatek,mt7623-eth" },
> +	{ .compatible = "mediatek,mt2701-eth" },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, of_mtk_match);





More information about the Linux-mediatek mailing list