[PATCH] clk: mediatek: remove superfluous line including linux/clk-provider.h

Sean Wang sean.wang at mediatek.com
Tue Dec 26 20:01:09 PST 2017


On Tue, 2017-12-26 at 17:15 -0800, Stephen Boyd wrote:
> On 12/25, sean.wang at mediatek.com wrote:
> > From: Sean Wang <sean.wang at mediatek.com>
> > 
> > clk-mtk.h has already included linux/clk-provider.h inside, so remove
> > the superfluous line including linux/clk-provider.h from these files which
> > also included clk-mtk.h.
> > 
> > Signed-off-by: Sean Wang <sean.wang at mediatek.com>
> > Cc: Jean Delvare <jdelvare at suse.de>
> > ---
> 
> Please don't do this. If anything, I would remove as many
> includes from clk-mtk.h as possible and forward declare the
> structures used in there so there isn't any header dependency.
> Then it becomes clear which C files are clk-provider drivers
> almost immediately because we have the include in the driver, and
> we also avoid any header dependency chains where we must include
> some header file if we want to get another header file's
> definitions.
> 

Agreed on above. 

It really becomes clearer to know which c files belong
to clock provider driver, not only just considering header dependency.
For these points, it should be kept there.

Thanks for your detailed explanation

	Sean





More information about the Linux-mediatek mailing list