On 05/10/2016 08:13 AM, Boris Brezillon wrote: >> + >> >+void mtk_ecc_hw_init(struct mtk_ecc *ecc) > No need to expose this function. Make it static and remove the > prototype in your header. > yes, it was a leftover.