[patch 1/2] iommu/mediatek: signedness bug in probe function

Joerg Roedel joro at 8bytes.org
Wed Mar 2 05:53:52 PST 2016


On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote:
> "larb_nr" needs to be signed for the error handling to work.  "i" can
> be int as well.
> 
> Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 721ffdb..1a4022c 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
>  	struct resource         *res;
>  	struct component_match  *match = NULL;
>  	void                    *protect;
> -	unsigned int            i, larb_nr;
> +	int			i, larb_nr;
>  	int                     ret;
>  
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);

I merged a similar fix from Andrzej Hajda yesterday.



More information about the Linux-mediatek mailing list