[PATCH v10 02/13] drm/mediatek: add *driver_data for different hardware settings
YT Shen
yt.shen at mediatek.com
Mon Dec 5 04:50:41 PST 2016
Hi Daniel,
On Wed, 2016-11-30 at 14:42 +0800, Daniel Kurtz wrote:
> Hi YT,
>
>
> On Fri, Nov 25, 2016 at 6:34 PM, YT Shen <yt.shen at mediatek.com> wrote:
> >
> > There are some hardware settings changed, between MT8173 & MT2701:
> > DISP_OVL address offset changed, color format definition changed.
> > DISP_RDMA fifo size changed.
> > DISP_COLOR offset changed.
> > MIPI_TX pll setting changed.
> > And add prefix for mtk_ddp_main & mtk_ddp_ext & mutex_mod.
>
> Sorry, I have not had time to thoroughly review the new patch set, but
> one quick comment:
>
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> > index 22a33ee..cfaa760 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> > @@ -78,6 +78,10 @@ struct mtk_ddp_comp_funcs {
> > struct drm_crtc_state *state);
> > };
> >
> > +struct mtk_ddp_comp_driver_data {
> > + unsigned int color_offset;
> > +};
> > +
> > struct mtk_ddp_comp {
> > struct clk *clk;
> > void __iomem *regs;
> > @@ -85,6 +89,7 @@ struct mtk_ddp_comp {
> > struct device *larb_dev;
> > enum mtk_ddp_comp_id id;
> > const struct mtk_ddp_comp_funcs *funcs;
> > + const struct mtk_ddp_comp_driver_data *data;
>
> I want to avoid adding this generic pointer here to all mtk_ddp_comp,
> since this is only used by the color component.
> Instead, define color specific types:
>
> struct mtk_disp_color_data {
> unsigned int offset;
> };
>
> struct mtk_disp_color {
> struct mtk_ddp_comp ddp_comp;
> const struct mtk_disp_color_data *data;
> };
>
> Then, add another comp_type check and fetch the dev data in
> mtk_drm_probe() or maybe mtk_ddp_comp_init().
>
> -Dan
OK, we will remove the color data pointer from generic mtk_ddp_comp.
Thanks.
Regards,
yt.shen
More information about the Linux-mediatek
mailing list