[RESEND PATCH net 05/10] net: ethernet: mediatek: fix logic unbalance between probe and remove
John Crispin
john at phrozen.org
Thu Aug 25 05:22:35 PDT 2016
On 25/08/2016 12:44, Sean Wang wrote:
> original mdio_cleanup is not in the symmetric place against where
> mdio_init is, so relocate mdio_cleanup to the right one.
>
> Signed-off-by: Sean Wang <sean.wang at mediatek.com>
Acked-by: John Crispin <john at phrozen.org>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 9883dac..5bd31f8 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1504,7 +1504,6 @@ static void mtk_uninit(struct net_device *dev)
> struct mtk_eth *eth = mac->hw;
>
> phy_disconnect(mac->phy_dev);
> - mtk_mdio_cleanup(eth);
> mtk_irq_disable(eth, ~0);
> }
>
> @@ -1915,6 +1914,7 @@ static int mtk_remove(struct platform_device *pdev)
> netif_napi_del(ð->tx_napi);
> netif_napi_del(ð->rx_napi);
> mtk_cleanup(eth);
> + mtk_mdio_cleanup(eth);
>
> return 0;
> }
>
More information about the Linux-mediatek
mailing list