[RESEND PATCH net 04/10] net: ethernet: mediatek: remove redundant free_irq for devm_request_irq allocated irq
John Crispin
john at phrozen.org
Thu Aug 25 05:20:19 PDT 2016
On 25/08/2016 12:44, Sean Wang wrote:
> these irqs are not used for shared irq and disabled during ethernet stops.
> irq requested by devm_request_irq is safe to be freed automatically on
> driver detach.
>
> Signed-off-by: Sean Wang <sean.wang at mediatek.com>
Acked-by: John Crispin <john at phrozen.org>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 1b131a1..9883dac 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1506,8 +1506,6 @@ static void mtk_uninit(struct net_device *dev)
> phy_disconnect(mac->phy_dev);
> mtk_mdio_cleanup(eth);
> mtk_irq_disable(eth, ~0);
> - free_irq(eth->irq[1], dev);
> - free_irq(eth->irq[2], dev);
> }
>
> static int mtk_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>
More information about the Linux-mediatek
mailing list