[PATCH] VPU: mediatek: fix simple_open.cocci warnings
Julia Lawall
julia.lawall at lip6.fr
Fri Apr 22 06:12:19 PDT 2016
Remove an open coded simple_open() function
and replace file operations references to the function
with simple_open() instead.
Generated by: scripts/coccinelle/api/simple_open.cocci
CC: Andrew-CT Chen <andrew-ct.chen at mediatek.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
Signed-off-by: Julia Lawall <julia.lawall at lip6.fr>
---
I'm just passing this along. Simple_open additionally has a check that
inode->i_private is not NULL, before doing the assignment. I don't know
if that difference is important in this case.
base: git://linuxtv.org/media_tree.git master
mtk_vpu.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
--- a/drivers/media/platform/mtk-vpu/mtk_vpu.c
+++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c
@@ -599,11 +599,6 @@ static void vpu_init_ipi_handler(void *d
}
#ifdef CONFIG_DEBUG_FS
-static int vpu_debug_open(struct inode *inode, struct file *file)
-{
- file->private_data = inode->i_private;
- return 0;
-}
static ssize_t vpu_debug_read(struct file *file, char __user *user_buf,
size_t count, loff_t *ppos)
@@ -646,7 +641,7 @@ static ssize_t vpu_debug_read(struct fil
}
static const struct file_operations vpu_debug_fops = {
- .open = vpu_debug_open,
+ .open = simple_open,
.read = vpu_debug_read,
};
#endif /* CONFIG_DEBUG_FS */
More information about the Linux-mediatek
mailing list