[PATCH v6 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller
chunfeng yun
chunfeng.yun at mediatek.com
Tue Sep 1 04:46:05 PDT 2015
hi,
On Sat, 2015-08-22 at 16:23 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 8/22/2015 4:45 AM, Chunfeng Yun wrote:
>
> > add a DT binding documentation of xHCI host controller for the
> > MT8173 SoC from Mediatek.
>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun at mediatek.com>
> > ---
> > .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++
> > 1 file changed, 52 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > new file mode 100644
> > index 0000000..8e6e463
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt
> > @@ -0,0 +1,52 @@
> > +mt65XX xHCI
>
> The file is called mt8173-xhci.txt. Are you sure MT65xx should be here?
>
I will revise it later.
> > +
> > +The device node for Mediatek SOC usb3.0 host controller
> > +
> > +Required properties:
> > + - compatible : should contain "mediatek,mt8173-xhci"
> > + - reg : specifies physical base address and size of the registers,
> > + the first one for MAC, the second for IPPC
> > + - interrupts : interrupt used by the controller
> > + - power-domains : a phandle to USB power domain node to control usb's
>
> USB's -- be consistent, please.
>
> > + mtcmos
> > + - vusb33-supply : regulator of usb avdd3.3v
> > +
> > + - clocks : a list of phandle + clock-specifier pairs, one for each
> > + entry in clock-names
> > + - clock-names : must contain
> > + "sys_ck": for clock of xHCI MAC
> > + "wakeup_deb_p0": for usb wakeup debounce clock of port0
> > + "wakeup_deb_p0": for usb wakeup debounce clock of port1
>
> USB.
>
> > +
> > + - phys : a list of phandle + phy specifier pairs
> > + - usb3-lpm-capable : supports USB3 LPM
> > + - mediatek,syscon-wakeup : phandle to syscon used to access usb wakeup
> > + control register
> > + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup
> > + mode; others means don't enable wakeup source of usb
>
> "Others mean" and "USB".
>
I will replace all 'usb' by "USB"
Thanks a lot, and sorry for later reply.
> [...]
>
> MBR, Sergei
>
More information about the Linux-mediatek
mailing list