[RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

Rob Herring robh+dt at kernel.org
Fri Oct 16 06:27:01 PDT 2015


On Fri, Oct 16, 2015 at 8:06 AM, Mark Rutland <mark.rutland at arm.com> wrote:
>> +     /* FIXME - use of_graph_get_port_by_id(np, 1) on newer kernels */
>> +     in_ep = of_graph_get_next_endpoint(np, NULL);
>
> Huh?
>
>> +     edidp = of_get_property(np, "edid", &size);
>
> This property wasn't mentioned in the binding document.
>
> Please describe it. If it's from a more generic binding, refer to that
> from the binding document.

It should be generic, but currently documented in individual drivers.
I also think this is not the right location in the DT for this
property. It should be part of the panel or connector node instead.

Rob



More information about the Linux-mediatek mailing list