[PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver

Alexandre Belloni alexandre.belloni at free-electrons.com
Thu May 7 05:06:01 PDT 2015


On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote :
> On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote:
> > From: Tianping Fang <tianping.fang at mediatek.com>
> 
> trivia: no need to resend now, maybe in a future patch.
> 
> > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> []
> > +static int mtk_rtc_probe(struct platform_device *pdev)
> > +{
> []
> > +	ret = request_threaded_irq(rtc->irq, NULL,
> > +				   mtk_rtc_irq_handler_thread,
> > +				   IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> > +			"mt6397-rtc", rtc);
> 
> It'd be nicer to align all the statement lines
> to that open parenthesis
> 
> 

I'll fix it up when applying.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the Linux-mediatek mailing list