[PATCH][V2] pinctrl: mediatek: mtk-common: initialize unmask

Linus Walleij linus.walleij at linaro.org
Mon May 4 06:20:47 PDT 2015


On Mon, Apr 20, 2015 at 5:59 PM, Colin King <colin.king at canonical.com> wrote:

> From: Colin Ian King <colin.king at canonical.com>
>
> cppcheck detected an uninitialized variable:
>
> [drivers/pinctrl/mediatek/pinctrl-mtk-common.c:897]:
>   (error) Uninitialized variable: unmask
>
> unmask should be initialized to zero to ensure unmasking
> only occurs if a previous mask occurred. The current situation
> is that the unmask variable could contain any random garbage
> causing random unexpected unmasking.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Patch applied for fixes.

Yours,
Linus Walleij



More information about the Linux-mediatek mailing list