[PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes

James Liao jamesjj.liao at mediatek.com
Sun Jul 26 19:56:22 PDT 2015


Hi Daniel,

On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote:
> > @@ -88,6 +88,13 @@
> >                 #clock-cells = <0>;
> >         };
> >
> > +       cpum_ck: dummy_clk {
> 
> I'm not a big fan of this "dummy_clk".
> The 'name' part of the devicetree node is supposed to be generic.
> So, perhaps just oscillator at 2, and move it down below clk32k: oscillator at 1.
> Otherwise:

cpum_ck is a test clock which only available in IC test. It's empty on
MT8173 evaluation or production boards. Should we name this kind of
empty clock as an oscillator? Or is there a better name for it?


Best regards,

James




More information about the Linux-mediatek mailing list