[PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator

Henry Chen HenryC.Chen at mediatek.com
Fri Jul 24 05:59:58 PDT 2015

Hi Javier,

On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote:
> Hello Henry,
> I believe Mark asked you to use a subject lines reflecting the style
> for the subsystem, so the subject should had been something like:
> regulators: mt6311: Add DT binding document
> On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen <henryc.chen at mediatek.com> wrote:
> > This patch adds a list of supported regulator names to the devicetree
> > binding documentation for Mediatek MT6311 PMIC.
> >
> > Signed-off-by: Henry Chen <henryc.chen at mediatek.com>
> > ---
> I know is in your cover letter, but usually is good to also include a
> history log of the changes for each patch so people know what changed.
> Everything between the '---' and the diff are omitted by tools like
> git am so you can add there.  You can use tools like patman that do
> this automatically for you.
Ok, got it, I will follow that.

> Also, I said that you could add my Reviewed-by after the node name
> change so you should had carried that. So again:

Sorry, did you mean I need to resent again?

Thanks for advise.

> Reviewed-by: Javier Martinez Canillas <javier at osg.samsung.com>
> Best regards,
> Javier

More information about the Linux-mediatek mailing list