[PATCH v2 2/2] regulator: mt6311: Add support for mt6311 regulator
Henry Chen
HenryC.Chen at mediatek.com
Wed Jul 22 07:42:54 PDT 2015
On Wed, 2015-07-22 at 14:50 +0200, Javier Martinez Canillas wrote:
> > +
> > +struct mt6311 {
> > + struct device *dev;
> > + struct regmap *regmap;
> > + struct regulator_dev *rdev[MT6311_MAX_REGULATORS];
> > + int num_regulator;
> > + int chip_cid;
> > +};
>
> It seems this struct can be removed, the rdev, num_regulator and
> chip_cid fields are set but not used and dev and regmap are only used
> to set the struct regulator_config fields in mt6311_regulator_init().
> But that won't be necessary if you just remove the
> mt6311_regulator_init() function and move the regulator registration
> logic to mt6311_i2c_probe().
Yes, it should be removed, thanks for the advise.
Henry
>
> Best regards,
> Javier
More information about the Linux-mediatek
mailing list