[PATCH 13/20] dt-bindings: pinctrl: berlin: Support Synaptics SL261X SoCs

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: pinctrl: undocumented schema relaxation for all SoCs
--

commit 85b4def57a8a9be19cfbb07ca389098832f3670a
Author: Jisheng Zhang <jszhang at kernel.org>
dt-bindings: pinctrl: berlin: Support Synaptics SL261X SoCs

This commit adds device tree binding support for the Synaptics SL261X SoCs
to the Marvell Berlin2 pinctrl schema. It also modifies the subnode schema
references to include generic pin configurations.

> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,berlin2-soc-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,berlin2-soc-pinctrl.yaml
> index 6ace3bf5433bd..fb60a310a24e6 100644
> --- a/Documentation/devicetree/bindings/pinctrl/marvell,berlin2-soc-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,berlin2-soc-pinctrl.yaml
[ ... ]
> @@ -44,8 +46,10 @@ properties:
>  additionalProperties:
>    description: Pin group configuration subnodes.
>    type: object
> -  $ref: /schemas/pinctrl/pinmux-node.yaml#
> -  additionalProperties: false
> +
> +  allOf:
> +    - $ref: /schemas/pinctrl/pinmux-node.yaml#
> +    - $ref: /schemas/pinctrl/pincfg-node.yaml#

[Severity: Medium]
Does this change unintentionally relax the schema for all older SoCs?

By universally adding the reference to pincfg-node.yaml here, generic pinconf
properties (like drive-strength or bias-pull-up) in pin configuration subnodes
will now silently pass validation for all existing SoCs (such as
marvell,berlin2-soc-pinctrl). These were previously explicitly rejected by
the removed additionalProperties: false declaration.

Since the commit message strictly states it only aims to support Synaptics
SL261X SoCs, should this schema relaxation be restricted to just the newly
added variants?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929061417.20733-1-jszhang@kernel.org?part=13