[PATCH v20 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

[sashiko-bot at kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] mfd: driver-specific header incorrectly placed in global include/linux/mfd/
--

commit ee0020c355157050632a39b51c33798536ac333a
Author: Aman Kumar Pandey <aman.kumarpandey at nxp.com>

    mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

This commit adds core MFD support for the NXP P3H2x4x family of multiport I3C
hub devices. The devices connect to a host via I3C/I2C/SMBus and expose
multiple downstream target ports.

> diff --git a/include/linux/mfd/p3h2840.h b/include/linux/mfd/p3h2840.h
> new file mode 100644
> index 0000000000000..eb4792de5440e
> --- /dev/null
> +++ b/include/linux/mfd/p3h2840.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright 2025-2026 NXP
> + */
> +
> +#ifndef _LINUX_MFD_P3H2840_H
> +#define _LINUX_MFD_P3H2840_H

[Severity: Low]
Could this newly introduced driver-specific header be moved to the local
drivers/mfd/ directory instead of being placed in the global
include/linux/mfd/ space?

The MFD subsystem guidelines specify that driver-specific headers containing
private structures like struct p3h2x4x should not be placed in the global
include/linux/mfd/ directory if they are only used by the parent and its
immediate children.

Placing it here causes a layering violation and introduces tight coupling by
polluting the global include space at compile time.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922103551.2754613-1-lakshay.piplani@nxp.com?part=4