[PATCH v19 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
sashiko-bot at kernel.org
sashiko-bot at kernel.org
Wed Sep 16 00:15:17 PDT 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing compatible in the required properties list
--
commit 99e5e0734a8e4028d9b6a9430b09604b1fe931b7
Author: Aman Kumar Pandey <aman.kumarpandey at nxp.com>
dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support
This commit adds device tree bindings for the NXP P3H2x4x multiport I3C
hub family. These devices connect to a host via I3C/I2C/SMBus and allow
communication with multiple downstream peripherals.
> diff --git a/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
> new file mode 100644
> index 0000000000000..09508a7bcbeb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml
[ ... ]
> + ldo-tpg1:
> + type: object
> + $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - reg
> + - '#address-cells'
> + - '#size-cells'
[Severity: Low]
Does this list incorrectly omit the compatible property?
Device tree nodes referenced directly via a schema $ref might incorrectly
pass validation if they omit the compatible property, as the schema does
not enforce its presence. If a parent schema uses $ref to include this
schema for a child node, and the child node lacks a compatible string,
validation would silently succeed.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916070728.1088801-1-lakshay.piplani@nxp.com?part=3
More information about the linux-i3c
mailing list