[EXT] Re: [PATCH v18 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support

[Lakshay Piplani]

> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    enum:
> >>> +      - nxp,p3h2440
> >>> +      - nxp,p3h2441
> >>> +      - nxp,p3h2840
> >>> +      - nxp,p3h2841
> >>
> >> I don't see improvements.
> >>
> >
> > For this one, could you let me know in a little bit more detail what you have
> in mind?
>
> I questioned if devices are compatible. It seems the answer was that yes. See
> writing bindings doc. There is plenty of examples showing how to express
> compatibility, if they are compatible.
>

Thanks, understood.

The variants share the same programming interface, so I'll express
this through fallback compatibles with nxp,p3h2840 as the base
compatible, e.g.
compatible = "nxp,p3h2441", "nxp,p3h2840";

This follows the fallback-compatible pattern used in other upstream
bindings.

Is this fine?

properties:
  compatible:
    oneOf:
      - const: nxp,p3h2840
      - items:
          - enum:
              - nxp,p3h2440
              - nxp,p3h2441
              - nxp,p3h2841
          - const: nxp,p3h2840

Regards
Lakshay

NXP Public