[PATCH V2 00/20] i3c: mipi-i3c-hci-pci: Add Runtime PM support

Adrian Hunter adrian.hunter at intel.com
Thu Jan 8 00:05:38 PST 2026


Hi

Changes in V2:
    Notably 3 new patches to factor out more common code.  Otherwise:

    i3c: mipi-i3c-hci: Reset RING_OPERATION1 fields during init
    i3c: mipi-i3c-hci: Ensure proper bus clean-up
	Add Frank's Rev'd-by

    i3c: master: Update hot-join flag only on success
	Add Fixes tag

    i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked()
    i3c: mipi-i3c-hci: Switch DAT bitmap allocation to devm_bitmap_zalloc()
	Add Frank's Rev'd-by

    i3c: mipi-i3c-hci: Switch PIO data allocation to devm_kzalloc()
	Remove 'use' from commit message
	Add Frank's Rev'd-by

    i3c: mipi-i3c-hci: Manage DMA deallocation via devres action
	Move hci_dma_free() below hci_dma_cleanup() to make patch look
	better to review.
	Frank suggested using devm_add_action_and_reset() but it doesn't
	work because the error path needs to call hci_dma_cleanup() before
	hci_dma_free.

    i3c: mipi-i3c-hci: Cache DAT in memory for Runtime PM restore
    i3c: mipi-i3c-hci: Introduce helper to restore DAT
    i3c: mipi-i3c-hci: Extract ring initialization from hci_dma_init()
    i3c: mipi-i3c-hci: Add DMA suspend and resume support
    i3c: mipi-i3c-hci: Refactor PIO register initialization
    i3c: mipi-i3c-hci: Add PIO suspend and resume support
	Add Frank's Rev'd-by

    i3c: mipi-i3c-hci: Factor out software reset into helper
	Add to the commit message a sentence about additional error message
	when a timeout happens

    i3c: mipi-i3c-hci: Factor out IO mode setting into helper
    i3c: mipi-i3c-hci: Factor out core initialization into helper
    i3c: mipi-i3c-hci: Factor out master dynamic address setting into helper
	New patches

    i3c: master: Introduce optional Runtime PM support
	None
	Frank suggested dispensing with rpm_allowed.  That would be OK for
	drivers that do not enable runtime PM, but the drivers that do
	enable runtime PM (i.e. dw-i3c-master.c	and svc-i3c-master.c) might
	be affected.  rpm_allowed can be removed when they are converted to
	the new approach.

    i3c: mipi-i3c-hci: Add optional Runtime PM support
	Use new i3c_hci_reset_and_init() and i3c_hci_set_master_dyn_addr()
	Use devm_pm_runtime_set_active_enabled() which allows
	i3c_hci_rpm_disable() to be dropped.
	SET_RUNTIME_PM_OPS -> RUNTIME_PM_OPS

    i3c: mipi-i3c-hci-pci: Add Runtime PM support
	None


This patch set adds Runtime PM support to mipi-i3c-hci and
mipi-i3c-hci-pci.

Notably, the master core is enhanced to optionally support
doing the RPM gets/puts needed to ensure a device is runtime
resumed for all bus operations.  That alleviates mipi-i3c-hci
from having to do it, and if the approach is accepted, would
allow other master drivers to drop their RPM gets/puts.

There are a number of small patches making various improvements
for things hit during development.  Plus a bunch of patches
preparing for the main changes which are covered in the last 3
patches.


Adrian Hunter (20):
      i3c: mipi-i3c-hci: Reset RING_OPERATION1 fields during init
      i3c: mipi-i3c-hci: Ensure proper bus clean-up
      i3c: master: Update hot-join flag only on success
      i3c: master: Replace WARN_ON() with dev_err() in i3c_dev_free_ibi_locked()
      i3c: mipi-i3c-hci: Switch DAT bitmap allocation to devm_bitmap_zalloc()
      i3c: mipi-i3c-hci: Switch PIO data allocation to devm_kzalloc()
      i3c: mipi-i3c-hci: Manage DMA deallocation via devres action
      i3c: mipi-i3c-hci: Cache DAT in memory for Runtime PM restore
      i3c: mipi-i3c-hci: Introduce helper to restore DAT
      i3c: mipi-i3c-hci: Extract ring initialization from hci_dma_init()
      i3c: mipi-i3c-hci: Add DMA suspend and resume support
      i3c: mipi-i3c-hci: Refactor PIO register initialization
      i3c: mipi-i3c-hci: Add PIO suspend and resume support
      i3c: mipi-i3c-hci: Factor out software reset into helper
      i3c: mipi-i3c-hci: Factor out IO mode setting into helper
      i3c: mipi-i3c-hci: Factor out core initialization into helper
      i3c: mipi-i3c-hci: Factor out master dynamic address setting into helper
      i3c: master: Introduce optional Runtime PM support
      i3c: mipi-i3c-hci: Add optional Runtime PM support
      i3c: mipi-i3c-hci-pci: Add Runtime PM support

 drivers/i3c/device.c                               |  46 ++-
 drivers/i3c/internals.h                            |   4 +
 drivers/i3c/master.c                               | 101 +++++-
 drivers/i3c/master/mipi-i3c-hci/core.c             | 344 +++++++++++++++------
 drivers/i3c/master/mipi-i3c-hci/dat.h              |   2 +-
 drivers/i3c/master/mipi-i3c-hci/dat_v1.c           |  45 ++-
 drivers/i3c/master/mipi-i3c-hci/dma.c              | 163 +++++++---
 drivers/i3c/master/mipi-i3c-hci/hci.h              |  12 +
 drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c |  17 +
 drivers/i3c/master/mipi-i3c-hci/pio.c              |  63 ++--
 include/linux/i3c/master.h                         |   4 +
 11 files changed, 613 insertions(+), 188 deletions(-)


Regards
Adrian



More information about the linux-i3c mailing list