[EXT] Re: [PATCH v16 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

[Lakshay Piplani]

Hi Krzysztof,

Thanks for the review.

> > +static const struct of_device_id p3h2x4x_i2c_of_match[] = {
> > +     { .compatible = "nxp,p3h2440", },
> > +     { .compatible = "nxp,p3h2441", },
> > +     { .compatible = "nxp,p3h2840", },
> > +     { .compatible = "nxp,p3h2841", },
>
> So devices are fully compatible? Why isn't this expressed in the binding? Or
> explained in the commit msg?
>

Yes, from this driver's point of view. All four share the register
interface used by the driver; the port count is read at runtime from
DEV_CAPAB. The x0/x1 variants differ in their default/debug power-up
configuration, and the driver applies the DT configuration during probe.

I will explain this in the binding description and the commit message.

Thanks
Lakshay

NXP Confidential