[PATCH V4 05/14] i3c: Make dev->desc locking assumptions explicit
Frank Li
Frank.li at oss.nxp.com
Thu Aug 6 11:31:33 PDT 2026
On Thu, Aug 06, 2026 at 04:18:48PM +0300, Adrian Hunter wrote:
> i3c_device_get_info() takes the bus normal-use lock before accessing
> dev->desc. Under that lock, the descriptor pointer is guaranteed to be
> valid for the duration of the access.
>
> Remove the unnecessary NULL check on dev->desc so the code more clearly
> reflects the locking rules and expected descriptor lifetime.
>
> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
> Acked-by: Mukesh Savaliya <mukesh.savaliya at oss.qualcomm.com>
> ---
Reviewed-by: Frank Li <Frank.Li at nxp.com>
>
>
> Changes in V4:
>
> Added Mukesh's Acked-by tag
>
> Changes in V3:
>
> New patch
>
>
> drivers/i3c/device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c
> index a3778282e84c..5e6df6de0283 100644
> --- a/drivers/i3c/device.c
> +++ b/drivers/i3c/device.c
> @@ -101,8 +101,7 @@ void i3c_device_get_info(const struct i3c_device *dev,
> return;
>
> i3c_bus_normaluse_lock(dev->bus);
> - if (dev->desc)
> - *info = dev->desc->info;
> + *info = dev->desc->info;
> i3c_bus_normaluse_unlock(dev->bus);
> }
> EXPORT_SYMBOL_GPL(i3c_device_get_info);
> --
> 2.53.0
>
More information about the linux-i3c
mailing list