[PATCH] i3c: Remove superfluous FIXME

Frank Li Frank.li at nxp.com
Tue Sep 23 14:20:18 PDT 2025


On Tue, Sep 23, 2025 at 10:35:58PM +0200, Wolfram Sang wrote:
> I2C adapters can already change timeout and retry parameters via IOCTL.
> This allows for better tuning to workloads compared to per-adapter
> defaults. So, the FIXME is not needed.
>
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
> ---

Reviewed-by: Frank Li <Frank.Li at nxp.com>

>  drivers/i3c/master.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index acaba4d53697..d946db75df70 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2564,8 +2564,6 @@ static int i3c_master_i2c_adapter_init(struct i3c_master_controller *master)
>  	adap->owner = master->dev.parent->driver->owner;
>  	adap->algo = &i3c_master_i2c_algo;
>  	strscpy(adap->name, dev_name(master->dev.parent), sizeof(adap->name));
> -
> -	/* FIXME: Should we allow i3c masters to override these values? */
>  	adap->timeout = HZ;
>  	adap->retries = 3;
>
> --
> 2.47.2
>



More information about the linux-i3c mailing list