[PATCH v2 2/2] i3c: Add driver for i3c-hub device

Krzysztof Kozlowski krzk at kernel.org
Wed Sep 17 17:10:03 PDT 2025


On 17/09/2025 23:20, Steven Niu wrote:
> +
> +static struct device_node *i3c_hub_get_dt_hub_node(struct i3c_hub *hub)
> +{
> +	struct device_node *node = hub->i3cdev->dev.parent->of_node;
> +	struct device_node *matched_node = NULL;
> +	int max_ids_matched;
> +	struct device_node *hub_node, *from;
> +	int node_ids_matched;
> +	u8 dcr;
> +	u32 id_csel, id_cp1, id_tpx;
> +	int ret;
> +
> +	max_ids_matched = 0;
> +
> +	hub_node = NULL;
> +	from = node;
> +	while (1) {
> +		hub_node = of_find_node_by_name(from, "hub");


Which part of previous NAK was not clear?

You ignored also review on patch #1, so now I question myself whether we
should even bother looking here.


Best regards,
Krzysztof



More information about the linux-i3c mailing list