[PATCH v2 1/2] dt-bindings: i3c: Add i3c-hub support.
Krzysztof Kozlowski
krzk at kernel.org
Wed Sep 17 17:07:05 PDT 2025
On 17/09/2025 23:20, Steven Niu wrote:
> Add device tree binding documentation for the i3c hub devices which follows
> the Intel I3C hub specification.
>
> Signed-off-by: Steven Niu <steven.niu.uj at renesas.com>
>
> ---
> Changes for V2:
> - Group the device device characteristics into groups:
> - control-port
> - target-group-x
> - target-port-x
I don't see you implementing the feedback.
NAK.
Also, never tested.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
More information about the linux-i3c
mailing list