[PATCH 4/5] i3c: mipi-i3c-hci: Remove function enter DBG() printouts

[Frank Li]

On Wed, Aug 27, 2025 at 01:30:08PM +0300, Jarkko Nikula wrote:
> These function enter DBG("") printouts are not very useful in error
> report point of view because they require code recompile. In which case
> they can be replaced with more informative debug prints if needed so
> remove them for now.

I think simple words should be enough

  Remove useless empty DBG("") functions to clean up code.

Frank
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula at linux.intel.com>
> ---
>  drivers/i3c/master/mipi-i3c-hci/core.c | 16 ----------------
>  1 file changed, 16 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index d532933ac7ab..9932945ecf06 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -121,8 +121,6 @@ static int i3c_hci_bus_init(struct i3c_master_controller *m)
>  	struct i3c_device_info info;
>  	int ret;
>
> -	DBG("");
> -
>  	if (hci->cmd == &mipi_i3c_hci_cmd_v1) {
>  		ret = mipi_i3c_hci_dat_v1.init(hci);
>  		if (ret)
> @@ -159,8 +157,6 @@ static void i3c_hci_bus_cleanup(struct i3c_master_controller *m)
>  	struct i3c_hci *hci = to_i3c_hci(m);
>  	struct platform_device *pdev = to_platform_device(m->dev.parent);
>
> -	DBG("");
> -
>  	reg_clear(HC_CONTROL, HC_CONTROL_BUS_ENABLE);
>  	synchronize_irq(platform_get_irq(pdev, 0));
>  	hci->io->cleanup(hci);
> @@ -267,8 +263,6 @@ static int i3c_hci_daa(struct i3c_master_controller *m)
>  {
>  	struct i3c_hci *hci = to_i3c_hci(m);
>
> -	DBG("");
> -
>  	return hci->cmd->perform_daa(hci);
>  }
>
> @@ -385,8 +379,6 @@ static int i3c_hci_attach_i3c_dev(struct i3c_dev_desc *dev)
>  	struct i3c_hci_dev_data *dev_data;
>  	int ret;
>
> -	DBG("");
> -
>  	dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);
>  	if (!dev_data)
>  		return -ENOMEM;
> @@ -410,8 +402,6 @@ static int i3c_hci_reattach_i3c_dev(struct i3c_dev_desc *dev, u8 old_dyn_addr)
>  	struct i3c_hci *hci = to_i3c_hci(m);
>  	struct i3c_hci_dev_data *dev_data = i3c_dev_get_master_data(dev);
>
> -	DBG("");
> -
>  	if (hci->cmd == &mipi_i3c_hci_cmd_v1)
>  		mipi_i3c_hci_dat_v1.set_dynamic_addr(hci, dev_data->dat_idx,
>  					     dev->info.dyn_addr);
> @@ -424,8 +414,6 @@ static void i3c_hci_detach_i3c_dev(struct i3c_dev_desc *dev)
>  	struct i3c_hci *hci = to_i3c_hci(m);
>  	struct i3c_hci_dev_data *dev_data = i3c_dev_get_master_data(dev);
>
> -	DBG("");
> -
>  	i3c_dev_set_master_data(dev, NULL);
>  	if (hci->cmd == &mipi_i3c_hci_cmd_v1)
>  		mipi_i3c_hci_dat_v1.free_entry(hci, dev_data->dat_idx);
> @@ -439,8 +427,6 @@ static int i3c_hci_attach_i2c_dev(struct i2c_dev_desc *dev)
>  	struct i3c_hci_dev_data *dev_data;
>  	int ret;
>
> -	DBG("");
> -
>  	if (hci->cmd != &mipi_i3c_hci_cmd_v1)
>  		return 0;
>  	dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);
> @@ -464,8 +450,6 @@ static void i3c_hci_detach_i2c_dev(struct i2c_dev_desc *dev)
>  	struct i3c_hci *hci = to_i3c_hci(m);
>  	struct i3c_hci_dev_data *dev_data = i2c_dev_get_master_data(dev);
>
> -	DBG("");
> -
>  	if (dev_data) {
>  		i2c_dev_set_master_data(dev, NULL);
>  		if (hci->cmd == &mipi_i3c_hci_cmd_v1)
> --
> 2.47.2
>
>
> --
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c