[PATCH 2/5] i3c: mipi-i3c-hci: Remove nonexistent ring interrupt
Frank Li
Frank.li at nxp.com
Fri Sep 12 07:23:24 PDT 2025
On Wed, Aug 27, 2025 at 01:30:06PM +0300, Jarkko Nikula wrote:
> Ring interrupt bit 7, INTR_WARN_INS_STOP_MODE was probably drafted at
> some point but is marked as reserved in the MIPI I3C HCI specification
> versions 1.1 and 1.2 that came out after the initial code and also in
> the earlier specification versions so remove it.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula at linux.intel.com>
> ---
Reviewed-by: Frank Li <Frank.Li at nxp.com>
> drivers/i3c/master/mipi-i3c-hci/dma.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
> index f5f5ab4db172..8bc9de189543 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/dma.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
> @@ -77,7 +77,6 @@
> #define INTR_TRANSFER_COMPLETION BIT(11)
> #define INTR_RING_OP BIT(10)
> #define INTR_TRANSFER_ERR BIT(9)
> -#define INTR_WARN_INS_STOP_MODE BIT(7)
> #define INTR_IBI_RING_FULL BIT(6)
> #define INTR_TRANSFER_ABORT BIT(5)
>
> @@ -278,7 +277,6 @@ static int hci_dma_init(struct i3c_hci *hci)
> INTR_TRANSFER_COMPLETION |
> INTR_RING_OP |
> INTR_TRANSFER_ERR |
> - INTR_WARN_INS_STOP_MODE |
> INTR_IBI_RING_FULL |
> INTR_TRANSFER_ABORT);
>
> @@ -795,9 +793,6 @@ static bool hci_dma_irq_handler(struct i3c_hci *hci)
> RING_CTRL_RUN_STOP);
> }
> }
> - if (status & INTR_WARN_INS_STOP_MODE)
> - dev_warn_ratelimited(&hci->master.dev,
> - "ring %d: Inserted Stop on Mode Change\n", i);
> if (status & INTR_IBI_RING_FULL)
> dev_err_ratelimited(&hci->master.dev,
> "ring %d: IBI Ring Full Condition\n", i);
> --
> 2.47.2
>
>
> --
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c
More information about the linux-i3c
mailing list