[PATCH V2 09/13] i3c: mipi-i3c-hci-pci: Change callback parameter

[Frank Li]

On Fri, Nov 14, 2025 at 08:13:52PM +0200, Adrian Hunter wrote:
> Change ->init() callback parameter from a pointer to the PCI device to a
> pointer to the locally defined mipi_i3c_hci_pci_info device information.

from PCI device pointer to mipi_i3c_hci_pci_info device pointer.


> This is in preparation for consistency when adding more callbacks that will
> need struct mipi_i3c_hci_pci_info.

Prepare to add more callbacks in mipi_i3c_hci_pci_info.

>
> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
> ---
>
>
> Changes in V2:
>
> 	Re-based
>
>
>  drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> index 8936e50eddf7..7bfb9fe337b6 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> @@ -15,11 +15,12 @@
>  #include <linux/platform_device.h>
>
>  struct mipi_i3c_hci_pci {
> +	struct pci_dev *pci;
>  	struct platform_device *pdev;
>  };
>
>  struct mipi_i3c_hci_pci_info {
> -	int (*init)(struct pci_dev *pci);
> +	int (*init)(struct mipi_i3c_hci_pci *hci);
>  };
>
>  static DEFINE_IDA(mipi_i3c_hci_pci_ida);
> @@ -50,14 +51,14 @@ static void __iomem *intel_priv(struct pci_dev *pci)
>  	return devm_ioremap(&pci->dev, base + INTEL_PRIV_OFFSET, INTEL_PRIV_SIZE);
>  }
>
> -static int intel_i3c_init(struct pci_dev *pci)
> +static int intel_i3c_init(struct mipi_i3c_hci_pci *hci)
>  {
> -	void __iomem *priv = intel_priv(pci);
> +	void __iomem *priv = intel_priv(hci->pci);
>
>  	if (!priv)
>  		return -ENOMEM;
>
> -	dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
> +	dma_set_mask_and_coherent(&hci->pci->dev, DMA_BIT_MASK(64));
>
>  	intel_reset(priv);
>
> @@ -80,6 +81,8 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
>  	if (!hci)
>  		return -ENOMEM;
>
> +	hci->pci = pci;
> +
>  	ret = pcim_enable_device(pci);
>  	if (ret)
>  		return ret;
> @@ -113,7 +116,7 @@ static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
>
>  	info = (const struct mipi_i3c_hci_pci_info *)id->driver_data;
>  	if (info && info->init) {
> -		ret = info->init(pci);
> +		ret = info->init(hci);
>  		if (ret)
>  			goto err;
>  	}
> --
> 2.51.0
>
>
> --
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c