[PATCH V2 03/13] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers
Frank Li
Frank.li at nxp.com
Fri Nov 14 11:44:21 PST 2025
On Fri, Nov 14, 2025 at 08:13:46PM +0200, Adrian Hunter wrote:
> Rename some Intel-related identifiers to ensure Intel-related identifiers
> begin "intel_" or INTEL_, and for brevity removing purposeless "PRIV" in
> preparation to add more register definitions.
>
> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
> ---
Reviewed-by: Frank Li <Frank.Li at nxp.com>
>
>
> Changes in V2:
>
> Rename 'intel_init' to 'intel_i3c_init'
> More explanation in commit message
>
>
> .../i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> index 3d854cee05df..d434e2962740 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> @@ -21,11 +21,11 @@ static DEFINE_IDA(mipi_i3c_hci_pci_ida);
>
> #define INTEL_PRIV_OFFSET 0x2b0
> #define INTEL_PRIV_SIZE 0x28
> -#define INTEL_PRIV_RESETS 0x04
> -#define INTEL_PRIV_RESETS_RESET BIT(0)
> -#define INTEL_PRIV_RESETS_RESET_DONE BIT(1)
> +#define INTEL_RESETS 0x04
> +#define INTEL_RESETS_RESET BIT(0)
> +#define INTEL_RESETS_RESET_DONE BIT(1)
>
> -static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
> +static int intel_i3c_init(struct pci_dev *pci)
> {
> unsigned long timeout;
> void __iomem *priv;
> @@ -39,21 +39,21 @@ static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
> dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
>
> /* Assert reset, wait for completion and release reset */
> - writel(0, priv + INTEL_PRIV_RESETS);
> + writel(0, priv + INTEL_RESETS);
> timeout = jiffies + msecs_to_jiffies(10);
> - while (!(readl(priv + INTEL_PRIV_RESETS) &
> - INTEL_PRIV_RESETS_RESET_DONE)) {
> + while (!(readl(priv + INTEL_RESETS) &
> + INTEL_RESETS_RESET_DONE)) {
> if (time_after(jiffies, timeout))
> break;
> cpu_relax();
> }
> - writel(INTEL_PRIV_RESETS_RESET, priv + INTEL_PRIV_RESETS);
> + writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
>
> return 0;
> }
>
> static struct mipi_i3c_hci_pci_info intel_info = {
> - .init = mipi_i3c_hci_pci_intel_init,
> + .init = intel_i3c_init,
> };
>
> static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
> --
> 2.51.0
>
>
> --
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c
More information about the linux-i3c
mailing list