[PATCH 03/13] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers

[Adrian Hunter]

On 13/11/2025 18:19, Frank Li wrote:
> On Thu, Nov 13, 2025 at 03:01:02PM +0200, Adrian Hunter wrote:
>> On 12/11/2025 17:57, Frank Li wrote:
>>> On Wed, Nov 12, 2025 at 12:03:29PM +0200, Adrian Hunter wrote:
>>>> Rename some Intel-related identifiers to ensure Intel-related identifiers
>>>> begin "intel_" or INTEL_, and for brevity.
>>>>
>>>> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
>>>> ---
>>>>  .../i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 18 +++++++++---------
>>>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>>>
>>>> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>>>> index 617826628dc4..c74cc511a344 100644
>>>> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>>>> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>>>> @@ -21,11 +21,11 @@ static DEFINE_IDA(mipi_i3c_hci_pci_ida);
>>>>
>>>>  #define INTEL_PRIV_OFFSET		0x2b0
>>>>  #define INTEL_PRIV_SIZE			0x28
>>>> -#define INTEL_PRIV_RESETS		0x04
>>>> -#define INTEL_PRIV_RESETS_RESET		BIT(0)
>>>> -#define INTEL_PRIV_RESETS_RESET_DONE	BIT(1)
>>>> +#define INTEL_RESETS			0x04
>>>> +#define INTEL_RESETS_RESET		BIT(0)
>>>> +#define INTEL_RESETS_RESET_DONE		BIT(1)
>>>
>>> These are already begin with INTEL.
>>
>> For brevity.  They are long and "PRIV" adds nothing.
> 
> Generally, needn't this type rename unless you need add more registers
> defination later and want to keep consistent.

Patch 12 adds:

#define INTEL_ACTIVELTR			0x0c
#define INTEL_IDLELTR			0x10

#define INTEL_LTR_REQ			BIT(15)
#define INTEL_LTR_SCALE_MASK		GENMASK(11, 10)
#define INTEL_LTR_SCALE_1US		(2 << 10)
#define INTEL_LTR_SCALE_32US		(3 << 10)
#define INTEL_LTR_VALUE_MASK		GENMASK(9, 0)