[PATCH 03/13] i3c: mipi-i3c-hci-pci: Rename some Intel-related identifiers

[Adrian Hunter]

On 12/11/2025 17:57, Frank Li wrote:
> On Wed, Nov 12, 2025 at 12:03:29PM +0200, Adrian Hunter wrote:
>> Rename some Intel-related identifiers to ensure Intel-related identifiers
>> begin "intel_" or INTEL_, and for brevity.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
>> ---
>>  .../i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>> index 617826628dc4..c74cc511a344 100644
>> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>> @@ -21,11 +21,11 @@ static DEFINE_IDA(mipi_i3c_hci_pci_ida);
>>
>>  #define INTEL_PRIV_OFFSET		0x2b0
>>  #define INTEL_PRIV_SIZE			0x28
>> -#define INTEL_PRIV_RESETS		0x04
>> -#define INTEL_PRIV_RESETS_RESET		BIT(0)
>> -#define INTEL_PRIV_RESETS_RESET_DONE	BIT(1)
>> +#define INTEL_RESETS			0x04
>> +#define INTEL_RESETS_RESET		BIT(0)
>> +#define INTEL_RESETS_RESET_DONE		BIT(1)
> 
> These are already begin with INTEL.

For brevity.  They are long and "PRIV" adds nothing.

> 
>>
>> -static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
>> +static int intel_init(struct pci_dev *pci)
> 
> intel_i3c_init() ?
> 
> Frank
> 
>>  {
>>  	unsigned long timeout;
>>  	void __iomem *priv;
>> @@ -42,21 +42,21 @@ static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
>>  		return ret;
>>
>>  	/* Assert reset, wait for completion and release reset */
>> -	writel(0, priv + INTEL_PRIV_RESETS);
>> +	writel(0, priv + INTEL_RESETS);
>>  	timeout = jiffies + msecs_to_jiffies(10);
>> -	while (!(readl(priv + INTEL_PRIV_RESETS) &
>> -		 INTEL_PRIV_RESETS_RESET_DONE)) {
>> +	while (!(readl(priv + INTEL_RESETS) &
>> +		 INTEL_RESETS_RESET_DONE)) {
>>  		if (time_after(jiffies, timeout))
>>  			break;
>>  		cpu_relax();
>>  	}
>> -	writel(INTEL_PRIV_RESETS_RESET, priv + INTEL_PRIV_RESETS);
>> +	writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
>>
>>  	return 0;
>>  }
>>
>>  static struct mipi_i3c_hci_pci_info intel_info = {
>> -	.init = mipi_i3c_hci_pci_intel_init,
>> +	.init = intel_init,
>>  };
>>
>>  static int mipi_i3c_hci_pci_probe(struct pci_dev *pci,
>> --
>> 2.51.0
>>
>>
>> --
>> linux-i3c mailing list
>> linux-i3c at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-i3c