[PATCH 02/13] i3c: mipi-i3c-hci-pci: Move all Intel-related definitions together

[Adrian Hunter]

On 12/11/2025 17:53, Frank Li wrote:
> On Wed, Nov 12, 2025 at 12:03:28PM +0200, Adrian Hunter wrote:
>> Move all Intel-related definitions together, to tidy the code slightly.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
>> ---
> 
> looks like not neccessary.

Sure, it is just a tidy-up.

It is confusing to have something non-Intel related in the middle
of all the Intel definitions.

> 
> Frank
> 
>>  drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>> index 850fcec4cacf..617826628dc4 100644
>> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
>> @@ -17,14 +17,14 @@ struct mipi_i3c_hci_pci_info {
>>  	int (*init)(struct pci_dev *pci);
>>  };
>>
>> +static DEFINE_IDA(mipi_i3c_hci_pci_ida);
>> +
>>  #define INTEL_PRIV_OFFSET		0x2b0
>>  #define INTEL_PRIV_SIZE			0x28
>>  #define INTEL_PRIV_RESETS		0x04
>>  #define INTEL_PRIV_RESETS_RESET		BIT(0)
>>  #define INTEL_PRIV_RESETS_RESET_DONE	BIT(1)
>>
>> -static DEFINE_IDA(mipi_i3c_hci_pci_ida);
>> -
>>  static int mipi_i3c_hci_pci_intel_init(struct pci_dev *pci)
>>  {
>>  	unsigned long timeout;
>> --
>> 2.51.0
>>
>>
>> --
>> linux-i3c mailing list
>> linux-i3c at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-i3c