[PATCH 07/13] i3c: mipi-i3c-hci-pci: Factor out intel_reset()
Adrian Hunter
adrian.hunter at intel.com
Wed Nov 12 02:03:33 PST 2025
For neatness, factor out intel_reset().
Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
---
.../master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 26 ++++++++++++-------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
index 003ae61e9f6c..b3b6b6f43af2 100644
--- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
+++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
@@ -34,18 +34,9 @@ static void __iomem *intel_priv(struct pci_dev *pci)
return devm_ioremap(&pci->dev, base + INTEL_PRIV_OFFSET, INTEL_PRIV_SIZE);
}
-static int intel_init(struct pci_dev *pci)
+static void intel_reset(void __iomem *priv)
{
- void __iomem *priv = intel_priv(pci);
u32 reg;
- int ret;
-
- if (!priv)
- return -ENOMEM;
-
- ret = dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
- if (ret)
- return ret;
/* Assert reset, wait for completion and release reset */
writel(0, priv + INTEL_RESETS);
@@ -53,6 +44,21 @@ static int intel_init(struct pci_dev *pci)
reg & INTEL_RESETS_RESET_DONE, 0,
INTEL_RESETS_TIMEOUT_US);
writel(INTEL_RESETS_RESET, priv + INTEL_RESETS);
+}
+
+static int intel_init(struct pci_dev *pci)
+{
+ void __iomem *priv = intel_priv(pci);
+ int ret;
+
+ if (!priv)
+ return -ENOMEM;
+
+ ret = dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(64));
+ if (ret)
+ return ret;
+
+ intel_reset(priv);
return 0;
}
--
2.51.0
More information about the linux-i3c
mailing list