[EXT] Re: [PATCH v2 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-hub device

[Krzysztof Kozlowski]

On 12/05/2025 13:45, Aman Kumar Pandey wrote:
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk at kernel.org>
>> Sent: Thursday, May 8, 2025 11:40 AM
>> To: Aman Kumar Pandey <aman.kumarpandey at nxp.com>; linux-
>> kernel at vger.kernel.org; linux-i3c at lists.infradead.org;
>> alexandre.belloni at bootlin.com; krzk+dt at kernel.org; robh at kernel.org;
>> conor+dt at kernel.org; devicetree at vger.kernel.org
>> Cc: Vikash Bansal <vikash.bansal at nxp.com>; Priyanka Jain
>> <priyanka.jain at nxp.com>; Shashank Rebbapragada
>> <shashank.rebbapragada at nxp.com>; Frank Li <frank.li at nxp.com>
>> Subject: [EXT] Re: [PATCH v2 2/2] drivers: i3c: Add driver for NXP P3H2x4x i3c-
>> hub device
>>
>> [Some people who received this message don't often get email from
>> krzk at kernel.org. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 08/05/2025 06:57, Aman Kumar Pandey wrote:
>>> +
>>> +static void p3h2x4x_of_get_tp_dt_conf(struct device *dev,
>>> +                                   const struct device_node *node) {
>>> +     struct p3h2x4x *priv = dev_get_drvdata(dev);
>>> +     struct device_node *dev_node;
>>> +     u64 tp_port;
>>> +
>>> +     for_each_available_child_of_node(node, dev_node) {
>>> +             if (!dev_node->name || of_node_cmp(dev_node->name,
>>> + "target-port"))
>>
>>
>> Same NAK as before. You ignored the comment and nothing improved.
>>
> 
> Thanks for reviewing the patch.
> As per your comment I have used proper function to get reg instead of sscanf. And our driver is not having direct interface with userspace.

What was the comment - undocumented ABI.

> What should I change here ?

How did you solve that comment?


Best regards,
Krzysztof