[PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver
Mukesh Kumar Savaliya
quic_msavaliy at quicinc.com
Fri Mar 28 07:29:44 PDT 2025
Hi Markus, Thanks for review !
On 3/28/2025 6:58 PM, Markus Elfring wrote:
> …
>> +++ b/drivers/i3c/master/qcom-i3c-master.c
>> @@ -0,0 +1,1107 @@
> …
>> +/* M_CMD OP codes for I2C/I3C */
>> +#define I3C_READ_IBI_HW 0
>> +#define I2C_WRITE 1
>> +#define I2C_READ 2
> …
>
> Can an enumeration become helpful here?
>
No, these are hardware program defined op-codes not created for any
software purpose. so Macro define looks fine to me.
> Regards,
> Markus
More information about the linux-i3c
mailing list