[PATCH v3 1/3] i3c: master: Add inline i3c_readl_fifo() and i3c_writel_fifo()

Wolfram Sang wsa+renesas at sang-engineering.com
Tue Jun 24 13:30:42 PDT 2025


On Tue, Jun 24, 2025 at 02:08:45PM -0400, Frank Li wrote:
> On Tue, Jun 24, 2025 at 11:06:04AM +0200, Jorge Marques wrote:
> > The I3C abstraction expects u8 buffers, but some controllers operate with
> > a 32-bit bus width FIFO and cannot flag valid bytes individually. To avoid
> > reading or writing outside the buffer bounds, use 32-bit accesses where
> > possible and apply memcpy for any remaining bytes
> >
> > Signed-off-by: Jorge Marques <jorge.marques at analog.com>
> 
> Reviewed-by: Frank Li <Frank.Li at nxp.com>
> 
> > ---
> >  drivers/i3c/internals.h | 37 +++++++++++++++++++++++++++++++++++++

Is there a reason we don't put this in 'include/linux/i3c/master.h'?
'internals.h' is used for the core only so far, and '#include
<../something.h>' also looks a bit like a layering violation.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-i3c/attachments/20250624/9d0381bd/attachment-0001.sig>


More information about the linux-i3c mailing list