[PATCH 2/2] i3c: master: Add driver for Analog Devices I3C Controller IP

[Jorge Marques]

Hi Wolfram,

On Thu, Jun 05, 2025 at 12:00:33AM +0200, Wolfram Sang wrote:
> Hi everyone,
> 
> On Wed, Jun 04, 2025 at 03:10:13PM -0400, Frank Li wrote:
> > On Wed, Jun 04, 2025 at 05:48:58PM +0200, Jorge Marques wrote:
> > > Add support for Analog Devices I3C Controller IP, an AXI-interfaced IP
> > > core that supports I3C and I2C devices, multiple speed-grades and
> > > I3C IBIs.
> > >
> > > Signed-off-by: Jorge Marques <jorge.marques at analog.com>
> 
> Hmm, I didn't get the original patches. They are probably still in the
> moderated queue?
> 

Yep the patch was held in the queue but are delivered now.

> > > +#define REG_VERSION			0x000
> > > +#define REG_ENABLE			0x040
> > > +#define REG_IRQ_MASK			0x080
> > > +#define REG_IRQ_PENDING			0x084
> > > +#define REG_CMD_FIFO			0x0d4
> > > +#define REG_CMDR_FIFO			0x0d8
> > > +#define REG_SDO_FIFO			0x0dc
> > > +#define REG_SDI_FIFO			0x0e0
> > > +#define REG_IBI_FIFO			0x0e4
> > > +#define REG_FIFO_STATUS			0x0e8
> > > +#define REG_OPS				0x100
> > > +#define REG_IBI_CONFIG			0x140
> > > +#define REG_DEV_CHAR			0x180
> 
> This register set has some 'cdns'-vibe to it. Maybe an earlier version?
> Not sure merging this into the cdns-driver is a good idea, the register
> set looks quite different to me. Note that I don't know cdns hardware, I
> just grew a habit of comparing register sets of new drivers to avoid
> duplicated drivers.
> 

This controller targets FPGAs, in particular low-cost ones. I am not
familar with cdns hw either. Overall the driver is strongly shaped by
the i3c ops, the spi-axi-spi-engine.c (also a FPGA IP) and the other
linux i3c controller drivers.

> Happy hacking,
> 
>    Wolfram

Best regards,
Jorge


> -- 
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c