[RFC] SAMA7D65 SoC I3C controller driver
Wolfram Sang
wsa+renesas at sang-engineering.com
Wed Jul 30 04:41:41 PDT 2025
Hi,
> So my query here are,
>
> 1.
> Whether this approach is correct or not.
> 2.
> Instead of creating a new driver file, shall we introduce a quirck
> for Microchip I3C and integrate the changes in the existing driver.
It depends, I would say. I would start with approach 2), but maybe not
call it 'quirks' but 'config'. If the code stays readable while working
on that, it probably is worth it to follow that road. If you are adding
so much code handling the differences that the result is hardly readable
anymore, then approach 1) might be the better one in the end. I don't
know your hardware, so I can't guess. But you might already have a gut
feeling which is better.
This is how it is handled in most subsystems I work with. Note that
Frank and Alexandre have the ultimate call here.
Happy hacking,
Wolfram
More information about the linux-i3c
mailing list