[PATCH RFT v2 4/5] i3c: mipi-i3c-hci: use get_parity8 helper instead of open coding it

Wolfram Sang wsa+renesas at sang-engineering.com
Fri Jan 3 13:17:02 PST 2025


> > Right, this is why the arguments of the ternary operator above are
> > exchanged. The old function was basically 'is_odd'.
> 
> Provided the high bit isn't already set - which it may not be.

Not here. Temporary I3C addresses are in the range 0-0x7f.

> add: 00010001 => xxxx0010 => xx10 => x1
> xor: 00010001 => xxxx0000 => 00xx => x0

This point goes to you :)

> I bet the target isn't checking...

Could be, I can't tell. I don't have this HW.

> So you might be fixing a bug.

Heh, which better argument could one have for a generic implementation.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-i3c/attachments/20250103/4cfbbf84/attachment-0001.sig>


More information about the linux-i3c mailing list