[PATCH 1/7] i3c: mipi-i3c-hci: Remove duplicate blank lines
Frank Li
Frank.li at nxp.com
Tue Dec 9 08:21:52 PST 2025
On Tue, Dec 09, 2025 at 01:50:58PM +0200, Adrian Hunter wrote:
> Remove duplicate blank lines from mipi-i3c-hci code.
>
> Signed-off-by: Adrian Hunter <adrian.hunter at intel.com>
> ---
Reviewed-by: Frank Li <Frank.Li at nxp.com>
> drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 --
> drivers/i3c/master/mipi-i3c-hci/cmd_v2.c | 2 --
> drivers/i3c/master/mipi-i3c-hci/core.c | 2 --
> drivers/i3c/master/mipi-i3c-hci/dat_v1.c | 1 -
> drivers/i3c/master/mipi-i3c-hci/dma.c | 2 --
> drivers/i3c/master/mipi-i3c-hci/ext_caps.c | 1 -
> drivers/i3c/master/mipi-i3c-hci/ext_caps.h | 1 -
> drivers/i3c/master/mipi-i3c-hci/hci.h | 5 -----
> drivers/i3c/master/mipi-i3c-hci/pio.c | 1 -
> 9 files changed, 17 deletions(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> index eb8a3ae2990d..fe260461e7e6 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> @@ -15,7 +15,6 @@
> #include "dat.h"
> #include "dct.h"
>
> -
> /*
> * Address Assignment Command
> */
> @@ -100,7 +99,6 @@
> #define CMD_M0_VENDOR_INFO_PRESENT W0_BIT_( 7)
> #define CMD_M0_TID(v) FIELD_PREP(W0_MASK( 6, 3), v)
>
> -
> /* Data Transfer Speed and Mode */
> enum hci_cmd_mode {
> MODE_I3C_SDR0 = 0x0,
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c
> index efb4326a25b7..3729e6419581 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v2.c
> @@ -16,7 +16,6 @@
> #include "cmd.h"
> #include "xfer_mode_rate.h"
>
> -
> /*
> * Unified Data Transfer Command
> */
> @@ -62,7 +61,6 @@
> #define CMD_A0_ASSIGN_ADDRESS(v) FIELD_PREP(W0_MASK( 14, 8), v)
> #define CMD_A0_TID(v) FIELD_PREP(W0_MASK( 6, 3), v)
>
> -
> static unsigned int get_i3c_rate_idx(struct i3c_hci *hci)
> {
> struct i3c_bus *bus = i3c_master_get_bus(&hci->master);
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 607d77ab0e54..211321f73e02 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -21,7 +21,6 @@
> #include "cmd.h"
> #include "dat.h"
>
> -
> /*
> * Host Controller Capabilities and Operation Registers
> */
> @@ -109,7 +108,6 @@
> #define DEV_CTX_BASE_LO 0x60
> #define DEV_CTX_BASE_HI 0x64
>
> -
> static inline struct i3c_hci *to_i3c_hci(struct i3c_master_controller *m)
> {
> return container_of(m, struct i3c_hci, master);
> diff --git a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c
> index 85c4916972e4..cc5d2deb23ab 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c
> @@ -15,7 +15,6 @@
> #include "hci.h"
> #include "dat.h"
>
> -
> /*
> * Device Address Table Structure
> */
> diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
> index c401a9425cdc..f20db2899989 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/dma.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
> @@ -20,7 +20,6 @@
> #include "cmd.h"
> #include "ibi.h"
>
> -
> /*
> * Software Parameter Values (somewhat arb itrary for now).
> * Some of them could be determined at run time eventually.
> @@ -124,7 +123,6 @@
> #define DATA_BUF_IOC BIT(30) /* Interrupt on Completion */
> #define DATA_BUF_BLOCK_SIZE GENMASK(15, 0)
>
> -
> struct hci_rh_data {
> void __iomem *regs;
> void *xfer, *resp, *ibi_status, *ibi_data;
> diff --git a/drivers/i3c/master/mipi-i3c-hci/ext_caps.c b/drivers/i3c/master/mipi-i3c-hci/ext_caps.c
> index 7714f00ea9cc..40939af0b0e3 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/ext_caps.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/ext_caps.c
> @@ -16,7 +16,6 @@
> #include "ext_caps.h"
> #include "xfer_mode_rate.h"
>
> -
> /* Extended Capability Header */
> #define CAP_HEADER_LENGTH GENMASK(23, 8)
> #define CAP_HEADER_ID GENMASK(7, 0)
> diff --git a/drivers/i3c/master/mipi-i3c-hci/ext_caps.h b/drivers/i3c/master/mipi-i3c-hci/ext_caps.h
> index 9df17822fdb4..b15e629951f0 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/ext_caps.h
> +++ b/drivers/i3c/master/mipi-i3c-hci/ext_caps.h
> @@ -13,7 +13,6 @@
> /* MIPI vendor IDs */
> #define MIPI_VENDOR_NXP 0x11b
>
> -
> int i3c_hci_parse_ext_caps(struct i3c_hci *hci);
>
> #endif
> diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h
> index 249ccb13c909..3f88b67bc5cc 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/hci.h
> +++ b/drivers/i3c/master/mipi-i3c-hci/hci.h
> @@ -62,7 +62,6 @@ struct i3c_hci {
> void *vendor_data;
> };
>
> -
> /*
> * Structure to represent a master initiated transfer.
> * The rnw, data and data_len fields must be initialized before calling any
> @@ -108,7 +107,6 @@ static inline void hci_free_xfer(struct hci_xfer *xfer, unsigned int n)
> kfree(xfer);
> }
>
> -
> /* This abstracts PIO vs DMA operations */
> struct hci_io_ops {
> bool (*irq_handler)(struct i3c_hci *hci);
> @@ -126,21 +124,18 @@ struct hci_io_ops {
> extern const struct hci_io_ops mipi_i3c_hci_pio;
> extern const struct hci_io_ops mipi_i3c_hci_dma;
>
> -
> /* Our per device master private data */
> struct i3c_hci_dev_data {
> int dat_idx;
> void *ibi_data;
> };
>
> -
> /* list of quirks */
> #define HCI_QUIRK_RAW_CCC BIT(1) /* CCC framing must be explicit */
> #define HCI_QUIRK_PIO_MODE BIT(2) /* Set PIO mode for AMD platforms */
> #define HCI_QUIRK_OD_PP_TIMING BIT(3) /* Set OD and PP timings for AMD platforms */
> #define HCI_QUIRK_RESP_BUF_THLD BIT(4) /* Set resp buf thld to 0 for AMD platforms */
>
> -
> /* global functions */
> void mipi_i3c_hci_resume(struct i3c_hci *hci);
> void mipi_i3c_hci_pio_reset(struct i3c_hci *hci);
> diff --git a/drivers/i3c/master/mipi-i3c-hci/pio.c b/drivers/i3c/master/mipi-i3c-hci/pio.c
> index 710faa46a00f..142f3f79415b 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/pio.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/pio.c
> @@ -15,7 +15,6 @@
> #include "cmd.h"
> #include "ibi.h"
>
> -
> /*
> * PIO Access Area
> */
> --
> 2.51.0
>
>
> --
> linux-i3c mailing list
> linux-i3c at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c
More information about the linux-i3c
mailing list