[PATCH v2 2/2] i3c: master: svc: Recycle unused IBI slot

Frank Li Frank.li at nxp.com
Fri Aug 29 07:58:35 PDT 2025


On Fri, Aug 29, 2025 at 09:23:09AM +0800, Stanley Chu wrote:
> In svc_i3c_master_handle_ibi(), an IBI slot is fetched from the pool
> to store the IBI payload. However, when an error condition is encountered,
> the function returns without recycling the IBI slot, resulting in an IBI
> slot leak.
>
> Fixes: c85e209b799f ("i3c: master: svc: fix ibi may not return mandatory data byte")
> Signed-off-by: Stanley Chu <yschu at nuvoton.com>
> ---

Reviewed-by: Frank Li <Frank.Li at nxp.com>

> Changes since v1:
>  * Add Fixes tag
> ---
>  drivers/i3c/master/svc-i3c-master.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index 8e7b4ab919e3..9641e66a4e5f 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -417,6 +417,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
>  						SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000);
>  	if (ret) {
>  		dev_err(master->dev, "Timeout when polling for COMPLETE\n");
> +		i3c_generic_ibi_recycle_slot(data->ibi_pool, slot);
>  		return ret;
>  	}
>
> --
> 2.34.1
>



More information about the linux-i3c mailing list