[PATCH] i3c: renesas: Simplify return statement in 'renesas_i3c_daa'

Tommaso Merciai tommaso.merciai.xr at bp.renesas.com
Mon Aug 4 01:57:55 PDT 2025


Hi Wolfram,
Thanks for your patch!

On Sun, Aug 03, 2025 at 11:12:57PM +0200, Wolfram Sang wrote:
> There was already a bail out for 'ret < 0', so we can always return
> success at the end of the function.
> 
> Reported-by: Dan Carpenter <dan.carpenter at linaro.org>
> Closes: https://lore.kernel.org/r/aIyzJ7HOENL1qp1l@stanley.mountain
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>

Tested-by: Tommaso Merciai <tommaso.merciai.xr at bp.renesas.com>

> ---
>  drivers/i3c/master/renesas-i3c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index 174d3dc5d276..275f7b924288 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -679,7 +679,7 @@ static int renesas_i3c_daa(struct i3c_master_controller *m)
>  			i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
>  	}
>  
> -	return ret < 0 ? ret : 0;
> +	return 0;
>  }
>  
>  static bool renesas_i3c_supports_ccc_cmd(struct i3c_master_controller *m,
> -- 
> 2.47.2
> 
>

Thanks & Regards,
Tommaso



More information about the linux-i3c mailing list