[bug report] i3c: master: Add basic driver for the Renesas I3C controller

Wolfram Sang wsa+renesas at sang-engineering.com
Sun Aug 3 14:04:07 PDT 2025


Hi Dan,

thanks for the report. I'd argue it is not a bug, though.

>     677         for (pos = 0; pos < i3c->maxdevs; pos++) {
>     678                 if (newdevs & BIT(pos))
>     679                         i3c_master_add_i3c_dev_locked(m, i3c->addrs[pos]);
> 
> Should we add checking for i3c_master_add_i3c_dev_locked()?

No, I think we should continue to add the remaining devices even if one
fails. Other driver do it also like above.

>     680         }
>     681 
> --> 682         return ret < 0 ? ret : 0;
> 
> Otherwise this could just be "return 0;"

True that, I will send a patch.

Happy hacking,

   Wolfram




More information about the linux-i3c mailing list