TODO : i3c/master/mipi-i3c-hci/dma.c

Jarkko Nikula jarkko.nikula at linux.intel.com
Mon Sep 30 06:02:46 PDT 2024


Hi

On 9/28/24 9:39 PM, cvam wrote:
> Hello Alexandre
> 
> This mail is regarding TODO present in the i3c/master/mipi-i3c-hci/dma.c, i
> would like to work on it, please give some more info what exactly we are
> referring here.
> 
> 
>                                  dev_err(&hci->master.dev,
>                                          "response tid=%d when expecting
> %d\n",
>                                          tid, xfer->cmd_tid);
>                                  /* TODO: do something about it? */
>                          }
>                          if (xfer->completion)
>                                  complete(xfer->completion);
> 
Well source code has minimum handling for unexpected but uncertain what 
to do about it. In my opinion "TODO" is a fair comment about it.

I'd leave it as it until somebody sees it on real and then we can debug 
does it need some steps in HW/SW point of view to recover.



More information about the linux-i3c mailing list