[PATCH v7 5/8] i3c: target: add svc target controller support
Joshua Yeong
joshua.yeong at starfivetech.com
Wed Mar 6 08:01:17 PST 2024
Hi Frank,
> -----Original Message-----
> From: linux-i3c <linux-i3c-bounces at lists.infradead.org> On Behalf Of Frank Li
> Sent: Tuesday, February 6, 2024 7:33 AM
> To: frank.li at nxp.com
> Cc: alexandre.belloni at bootlin.com; conor.culhane at silvaco.com;
> devicetree at vger.kernel.org; gregkh at linuxfoundation.org;
> ilpo.jarvinen at linux.intel.com; imx at lists.linux.dev; jirislaby at kernel.org;
> joe at perches.com; krzysztof.kozlowski+dt at linaro.org;
> krzysztof.kozlowski at linaro.org; linux-i3c at lists.infradead.org; linux-
> kernel at vger.kernel.org; linux-serial at vger.kernel.org;
> miquel.raynal at bootlin.com; robh at kernel.org;
> zbigniew.lukwinski at linux.intel.com
> Subject: [PATCH v7 5/8] i3c: target: add svc target controller support
>
> Add Silvaco I3C target controller support
>
> Signed-off-by: Frank Li <Frank.Li at nxp.com>
> ---
>
> Notes:
> Change from v2 to v3
> - fix build warning
>
> drivers/i3c/master/Makefile | 2 +-
> drivers/i3c/master/svc-i3c-main.c | 35 +-
> drivers/i3c/master/svc-i3c-target.c | 776
I think putting target mode files under "master" might not make sense. We might have to
consider that we may have a "secondary master" mode. Some other ways of splitting
or handling of target mode is needed here.
...
> +
> +#define I3C_SCONFIG 0x4
> +#define I3C_SCONFIG_SLVENA_MASK BIT(0)
> +#define I3C_SCONFIG_OFFLINE_MASK BIT(9)
> +#define I3C_SCONFIG_SADDR_MASK GENMASK(31, 25)
> +
> +#define I3C_SSTATUS 0x8
> +#define I3C_SSTATUS_STNOTSTOP_MASK BIT(0)
> +#define I3C_SSTATUS_STOP_MASK BIT(10)
> +#define I3C_SSTATUS_RX_PEND_MASK BIT(11)
> +#define I3C_SSTATUS_TXNOTFULL_MASK BIT(12)
> +#define I3C_SSTATUS_DACHG_MASK BIT(13)
> +#define I3C_SSTATUS_EVDET_MASK GENMASK(21, 20)
> +#define I3C_SSTATUS_EVDET_ACKED 0x3
> +#define I3C_SSTATUS_IBIDIS_MASK BIT(24)
> +#define I3C_SSTATUS_HJDIS_MASK BIT(27)
> +
There is couple of space formatting here that requires to be fixed.
Cheers,
Joshua
More information about the linux-i3c
mailing list